LibGfx/JPEG: Add a deringing pass to the encoder#26313
LibGfx/JPEG: Add a deringing pass to the encoder#26313LucasChollet merged 1 commit intoSerenityOS:masterfrom
Conversation
github-actions
bot
added
the
👀 pr-needs-review
LucasChollet
force-pushed
the
jpeg_deringing
branch
from
4e2cd96 to
f1aba02
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
The idea is described here https://kornel.ski/deringing/. And allows reducing the noise around sharp white edges. This is visible when encoding an image like `buggie.png`. One nice aspect of the optimization is that it only affects macroblocks where it can help.
LucasChollet
force-pushed
the
jpeg_deringing
branch
from
f1aba02 to
3d8aa67
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions! |
github-actions
bot
removed
the
👀 pr-needs-review
github-actions
bot
added
the
👀 pr-needs-review
|
@nico do you want to take a look at this? |
I do! I did look at it a few weeks ago and it looked sufficiently different from ImageOptim/mozjpeg-cocoa@ecb1751 that I got scared, decided I needed more time, and then didn't get back to it. If you're reasonably confident that it's good, feel free to just hit merge! :) |
|
I think it's good to go, but I always like your feedback so I'll let the PR open until the next round of the stale bot. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
|
It's time to get that in tree! |
github-actions
bot
removed
the
👀 pr-needs-review
nico
left a comment
nico
left a comment
There was a problem hiding this comment.
Looks like I had a pending nit. Feel free to ignore!
What confused me when looking at this is that the linked-to method seems to do more, like clipping at both min and max ends, while this one I think only clips at max. But can't argue with the screenshots :) And I don't fully understand the linked-to method yet, so maybe I'm misunderstanding what it (and this) does.
Thanks for the patch, very cool!
|
It does indeed only cover the top of the curve, so there are some gains to get in the dark regions too! They are probably less noticeable though. |
2 participants
The idea is described here https://kornel.ski/deringing/. And allows reducing the noise around sharp white edges. This is visible when encoding an image like
buggie.png. One nice aspect of the optimization is that it only affects macroblocks where it can help.Before:
After:
Diff:
